Update guzzle client #76
Merged
+10
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,6 +6,10 @@ | |||
|
|
|||
| - Client factories for Buzz. | |||
|
|
|||
| ### Changed | |||
|
|
|||
| - Guzzle 6 client now uses the new `createWithConfig` named constructor | |||
There was a problem hiding this comment.
this is very technical. i think for the user, its more relevant to know what that means:
- Guzzle 6 client is now created according to the Httplug specifications with automated minimal behaviour. Make sure you configure the Httplug plugins as needed, for example if you want to get exceptions for failure HTTP status codes.
sagikazarmark
force-pushed
the
guzzle_default_fix
branch
from
c97952f to
2a9c54e
Compare
|
@dbu anything else here from your POV? |
| @@ -37,6 +37,7 @@ | |||
| "puli/symfony-bundle": "^1.0@beta" | |||
| }, | |||
| "conflict": { | |||
| "php-http/guzzle6-adapter": "<1.1", | |||
There was a problem hiding this comment.
Im not sure this line is needed.
There was a problem hiding this comment.
If someone installs 1.0.0, Guzzle 6 factory will emit an error.
|
👍 |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.