-
Notifications
You must be signed in to change notification settings - Fork 50
Update guzzle client #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -6,6 +6,10 @@ | |||
|
|||
- Client factories for Buzz. | |||
|
|||
### Changed | |||
|
|||
- Guzzle 6 client now uses the new `createWithConfig` named constructor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is very technical. i think for the user, its more relevant to know what that means:
- Guzzle 6 client is now created according to the Httplug specifications with automated minimal behaviour. Make sure you configure the Httplug plugins as needed, for example if you want to get exceptions for failure HTTP status codes.
c97952f
to
2a9c54e
Compare
@dbu anything else here from your POV? |
@@ -37,6 +37,7 @@ | |||
"puli/symfony-bundle": "^1.0@beta" | |||
}, | |||
"conflict": { | |||
"php-http/guzzle6-adapter": "<1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im not sure this line is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If someone installs 1.0.0, Guzzle 6 factory will emit an error.
👍 |
thanks! |
No description provided.